Friday, August 31, 2007

07.CodeRulerReview

  • Reviewer: Chiao-Fen Zielinski
  • Reviewee: Jared Sunouchi
  • Review Comments:

File
Lines
Violation
Comments
MyRuler.java
10
EJS-35
The MyRuler class
MyRuler.java
52
EJS-46
@param String
MyRuler.java
104,105,236,*
EJS-9
Use meaningful name


After I read the book "The Elements of Java Style", I went through Jared's MyRuler, I could not find more than 3 violations in his code. I guess he has a good knowledge of Java coding and documentation standards. After I ran Jared's code, he codes his peasants to cover every single land that have not yet been owned. Reading someone else's code, it gave me an opportunity to compare my code and others. Then, I can absorb those good coding and forget those bad coding habits.

No comments: