MyIsern-Onyx-2.0 Review

• Team Pink decided to distribute the review assignment into four parts.

• Chiao-Fen: Java Code/Testing Review
  

• Ivan: Derby Database Review
  

• Ka Yee: Web Application Review
  

• Michal: Prime Directives Review

• Reviewee: Team Onyx

• Installation Review:
• I was able to download the zip file (myisern-onyx-2.0.1205.zip) from the team Onyx google hosting project site (http://code.google.com/p/myisern-onyx/).
• In the zip file, team Onyx provides a readme file which has a great detail about how to install their system and view their web application.

• Code Format and Conventions Review:

• 
• Quality Assurance Tools Review:

• 

• "CREATE TABLE " appears 8 times.
• "tbl_RESEARCHER" appears 4 times.
• "INSERT_INTO " appears 6 times.
• "VALUES (" appears 6 times.
• "'," appears 6 times.
• "FROM " appears 4 times.
  

• 
• Most of warnings are about the "nonconstant string passed to execute method on an SQL statement." Consider using a prepared statement instead.
• Some warnings are about using the plus sign (+) to add string together in a loop. Consider using a StringBuffer or StringBuilder in Java 1.5.
• A few of warnings are about unread field. Consider removing them.
  

• Testing Tools Review:

• 

• There are no derby unit tests.

• Test Case Review:
• After involving "ant -f emma.build.xml", the emma coverage had shown as below.

• 
• Team Onyx misses a few test cases for class such as LogoutActionBean, SanityCheckErrorItem, SanityCheckErrorMessage, and MyIsernXMLSaver.

• Summary:
• I believe that most groups focus on how to use the database with their web application. Hence, some groups might have neglected to take care of the code qualities and testings. I will suggest team Onyx to take a look at our review reports on four different parts of their project. Hopefully, these reports will provide a great help for them to improve their project.