29.MyISERN-1.3-Review

• Reviewer: Chiao-Fen Zielinski-Liu

• Author: Silver Group (Matsuo & Zhang)

• Installation Review:
• The myisern-silver-1.3.1114 zip file was successfully downloaded into to my workplace.
• Myisern-silver-1.3.1114 does not have a 'java - jar' interface to the system.
• I was able to run myisern-silver in a few minutes because the InstallationGuide was very clear and easy to follow. Myisern-silver also provides a link to their login page in the InstallationGuide. I find this so sweet.
• CheckStyle = failed.
• JUnit = failed.
• PMD = successful.
• FindBugs = failed.

• Code Format and Conventions Review:
• After running the 'CheckStyle' task, there were several warnings. These warnings are all about 'Missing a Javadoc comment'. Hence, it violates 'EJS-35' which is about 'no documentation comments'.

• Test Case Review:
• Black box perspective:
• There are two unit test classes which are 'TestMyIsernModel' and 'TestXmlLoader'. I believe that several unit tests for the MyIsernAction class are missing.
  
• White box perspective:
• Bring up tomcat, involve ant -f tomcat.build.xml, and then run the emma task. I kept getting a message called "could not find ${env.HOME} coverage.ec to copy. However, I changed to ${basedir} coverage.ec. The emma coverage is as follow for the myisern-silver group.
  

• [concat] Emma Coverage summary
• [concat] class: 22% (2/9)
• [concat] method: 26% (40/152)
• [concat] block: 53% (1533/2899)
• [concat] line: 47% (260.2/550)

• Break da buggah:
• I could access myisern.jsp and other *.jsp without entering valid username and password. I would suggest to lock other web applications if users try to visit other web application without signing in.
  
• I could successfully login the system. However, when I tried to involve more functions, I received a warning "HTTP Status 500-, Exception report".

• User Interface Review:
• The user interface for all of web applications is very simple and clear without any fancy images or background color. It contains only boxes for entering information, links, and buttons with white color as background. This user interface is good for users do multi tasks on the window at the same time.

• Summary and Lessons Learned:
• I would like to mention again that the installation guide is clear and concise. If any user follows it, it is impossible to make mistake.
• The only button that works successfully is the 'login' button. I could not involve any function after I signed in. Therefore, I believe that I would try to make at least one function work successfully.
• This assignment is very interesting because it involves the web application. What if this assignment was an individual project and more time was given, it would be more challenge for each of us in class.